Update action to use node 16
der-eismann opened this issue · comments
edit from the maintainers: This is now implemented! Please see this comment on how to update your action configuration. The original issue continues below.
Hello, thanks for the convenient action! Unfortunately it is a bit outdated, because it still uses the node12 runtime which isn't supported on self-hosted runners Apple Silicon / arm64 architecture.
Would you kindly update the action so it uses the node16 runtime instead?
Thanks for the request @der-eismann,
We'll start thinking about our next major version release so that we can support this 🙂
+1
Github started giving deprecation annotations to my workflows containing this action:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: aws-actions/configure-aws-credentials, aws-actions/configure-aws-credentials
There is already #413 open, it shouldn't be that hard.
Also waiting for this node 16 to be updated
"Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: aws-actions/configure-aws-credentials
Started seeing this warning as well; sure it's all over the place:
Thanks everyone for letting us know about the need to upgrade the Node runtime for this action.
We cannot merge these PRs as they are unfortunately, because to make this change we need to do so on a new major version. The reason for this is that changing the Node version we could be breaking cases where the runners used don't have node 16 installed.
Since this issue has come up we have a strong need to release the next major version. We are working hard to deliver this, but there are a number of things that have to be done behind the scenes first. I will try to provide an ETA here when possible, thanks all for your patience 🙂
@peterwoodworth We're seeing this warning somewhere in the hundreds of times each day right now, and it creates a substantial amount of noise for our engineers. Please consider ways to release a Node 16 update ahead of other planned changes for the next release; perhaps an early major version with only this change is a possibility.
For what it's worth, my opinion is that GitHub could have more carefully thought through the way they provide deprecation warnings and done so in a way that wasn't so disruptive to normal development.
Thanks everyone for letting us know about the need to upgrade the Node runtime for this action.
We cannot merge these PRs as they are unfortunately, because to make this change we need to do so on a new major version. The reason for this is that changing the Node version we could be breaking cases where the runners used don't have node 16 installed.
Since this issue has come up we have a strong need to release the next major version. We are working hard to deliver this, but there are a number of things that have to be done behind the scenes first. I will try to provide an ETA here when possible, thanks all for your patience 🙂
#521 is a similar one that will cause warnings and will cause a breakage when they disable it
While the planned change to node 16 is to take effect Summer 2023 according to the deprecation notice, the deprecation warnings are disruptive by generating a lot of noise. Piling this and a lot of new stuff into the next major version does not sound like quick process. I think the suggestion of addressing this (and the ::set-output issue) in a new major version is excellent, assuming it is practical to separate out upcoming major version changes.
Hi everyone. Our aim with versioning is to strictly ensure that no breakage will happen within a major version for our software - this is true in this action and the AWS SDKs as well. Because of that, we didn't want to move the v1 release of this action to using Node 16, in case this precludes those that have obsolete environments or odd edge cases from simply pointing their runners at v1. That said, we know that not seeing those deprecation warnings on GitHub is important to some folks, and rather than have you wait for us to go through and bundle all of our potentially breaking changes into a big v2 release, we wanted to unblock you right away.
As of right now you can change your action configuration to use v1-node16 instead of v1.
The only changes to this branch are that the action will now run with Node 16 instead of Node 12. We won't be providing a moving tag with this version, as it's supposed to be a temporary fix. Instead, we'll be merging any updates from master to the tip of v1-node16, including security updates. If you track v1-node16, you'll also run with these updates.
In the future we plan to provide at least security updates as long as is practical for v1, v1-node16, and v2.
@kellertk Do you know what the state is for other popular tasks like: ECS-Render-Task-Definition?
Will there be similar branches available?
@kellertk Do you know what the state is for other popular tasks like: ECS-Render-Task-Definition?
Will there be similar branches available?
I'm not sure about that action, because a different AWS team is responsible for it. But I'll poke around internally and see if we can't get a better answer there.
edit: I've reached out to the team that owns this and they're going to consider taking a similar approach. Make sure to watch the aws-actions/amazon-ecs-render-task-definition repo for any updates there!
- Temporary bumping of aws-actions/amazon-ecr-login: https://github.com/fac/freeagent/pull/39968
Am I correct in thinking that once v2 is released that it will run Node 16?
I am totally OK with the error messages and being super ultra lazy, I rather just update once and only after the next release is ready.
v2 will run at least Node 16 😃
when?
Is nodejs v16 coming for aws-actions/configure-aws-credentials@v1 ?
It's already here @leonk-sportsbet! But we have that on a separate branch v1-node16, so you will want to configure your action to use aws-actions/configure-aws-credentials@v1-node16. See this comment for more information on why and our future plans
Thoughts on locking this issue for future comments? I think it's pretty clear what the plan is here and locking it will maybe force folks to read what's already been written.
I'm mostly interested when v2 lands and I imagine this issue being closed will signal that. Thank you contributors for being so responsive on this issue!
Hi everyone, I'll be locking this thread for now (see the comment from @sterlingwes above for why). If you have any issues with the @v1-node16 branch please open a new issue. We'll close this issue when v2 is released.
This is now complete. Please use the v2 tag in all of your action runs.