awolden / brakes

Hystrix compliant Node.js Circuit Breaker Library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect terminology around circuit breaking

awolden opened this issue · comments

Right now when a circuit is broken it registers it as being closed, and when a circuit is still viable it registers it as open. These are backwards. The terminology should be changed such that:

open: requests automatically fail and and circuit is tripped
closed: requests are properly flowing through to the request function passed