awkward / Ocarina

A library to get metadata and Open Graph information from URLs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

404 status code does not give a failure

thierrybucco opened this issue · comments

In OcarinaManager in taskDidComplete receiving a 404 statusCode will not execute failure block.

if let response = response, response.statusCode < 200 && response.statusCode >= 300 {

it should be response.statusCode < 200 || response.statusCode >= 300

Also it would be nice to expose HTTPURLResponse in error.UserInfo

That was a good catch, I've approved and merged your PR: #11