404 status code does not give a failure
thierrybucco opened this issue · comments
Thierry Bucco commented
In OcarinaManager in taskDidComplete receiving a 404 statusCode will not execute failure block.
if let response = response, response.statusCode < 200 && response.statusCode >= 300 {
it should be response.statusCode < 200 || response.statusCode >= 300
Also it would be nice to expose HTTPURLResponse in error.UserInfo
Rens Verhoeven commented
That was a good catch, I've approved and merged your PR: #11
Thierry Bucco commented
Thanks!