CALL FOR NEW DATA
caesar0301 opened this issue · comments
Please follow the instruction to join the awesome public data community,
https://github.com/awesomedata/apd-core/blob/master/CONTRIBUTING.md
It's not very clear.
Please add some example (with complete items).
You did not understand me.
I mean that the document: https://github.com/awesomedata/apd-core/wiki/HOW_TO_CONTRIBUTE-%E5%A6%82%E4%BD%95%E8%B4%A1%E7%8C%AE not It is very clear, because the example you provide does not explain how each point is completed and what impact it has on the final file that the bot creates.
You could edit the Wiki better to add more documentation and that way more people would collaborate.
From having just added a dataset to APD, I can say there seems to be only four variables in the YAML that currently transfer to the APD readme:
title-- used as the visible texthomepage-- used as the link/hrefcategory-- used to place the dataset under the appropriate headingdescription-- appended to thetitlein the visible text
The YAML -> Markdown conversion looks like:
[{title}]({homepage}) - {description}with description truncated as needed.
Why are so many pull requests kept in pending state inspite of passing travis ci build tests?
@ishandutta2007 Dont worry. Let the Bullets Fly :)
???
It seems now you have merged some. I think it's better if you add a short comment mentioning the reason for the rest, doing so will help new contributors to be on the same page.
I explained why I gave labels to some PRs in #67 (comment). I really want this to be a pure high-quality data sharing repo. No advertisement! No spam! No reputation promotion! Maybe, sometimes actually, I gave a wrong judgement about the quality of a request. I want you some people, jump out, and point out that I gave a wrong decision. I will fix my label when I am convinced and give each request a responsible review. Thank you all contributors!
@ishandutta2007 "Let the bullets fly", a modern Chinese film name. We sometime use this phrase to tell people to take it easy. The metaphor means the bullet you fired out will achieved its target, eventually. If not, its justing flying its way. :)
My point is, if it fails your criteria it should fail the test right a way. is it too hard to automate it ?
The amount of time that you might have spent manually reviewing might be more than what writing a quick test to handle that scenario.
@ishandutta2007 Yes I know. Am trying to automate validation as best as I can. But to my programming experience, some criteria are hard to implemented as code, say fake submission for ads.
Create a pending validation list, and share it, let the open souce community help you on those too, I will see if I can take up any.
Let's keep that list on issues itself with "feature request" label and we will close it ony when all from that list gets done. If new validation comes up, we will just add to it and keep the issue open.