how to set `node[shape=box style=rounded labelloc=b]` global attribute?

[唐盛军]

it's not allowed use like this:

graph.AddAttr(workflowName, "node", "shape=rect style=rounded, labelloc=b")

but if set attribute one by one, it will not take affect.

graph.AddAttr(workflowName, "shape", "rect")
graph.AddAttr(workflowName, "style", "rounded")
graph.AddAttr(workflowName, "labelloc", "b")

[Walter Schulze]

Can you show another screenshot picture where it has taken effect with the graphviz code as well?

…

On Fri, 20 Sep 2019 at 03:25, 唐盛军 ***@***.***> wrote: it's not allowed use like this: graph.AddAttr(workflowName, "node", "shape=rect style=rounded, labelloc=b") but if set attrubete one by one, it will not take affect. graph.AddAttr(workflowName, "shape", "rect") graph.AddAttr(workflowName, "style", "rounded") graph.AddAttr(workflowName, "labelloc", "b") [image: image] <https://user-images.githubusercontent.com/7219402/65294355-ee390a80-db90-11e9-951d-19c91773696d.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55?email_source=notifications&email_token=AAN6YLIKCV6RLPYHUYFH6STQKQYBVA5CNFSM4IYR56JKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMSA3VA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN6YLPQM2HHYGAYFRCZMR3QKQYBVANCNFSM4IYR56JA> .

[唐盛军]

finally I have to add Global attribute to every Node by:

for _, node := range(graph.Nodes.Nodes) {
   node.Attrs.Add("shape", "rect")
   node.Attrs.Add("style", "rounded")
   node.Attrs.Add("labelloc", "b")
}

if can support this grammar, that will be great (by the way, it's pretty good now):
node[shape=rect style=rounded labelloc=b]

like：

attrs := make(map[string]string)
attrs["shape"] = "rect"
attrs["style"] = "rounded"
attrs["labelloc"] = "b"
graph.AddNodeAttr(workflowName, attrs)

type Graph struct {
	Attrs     Attrs
        NodeAttrs     Attrs  //<== maybe need this one ?
        EdgeAttrs     Attrs  //<== same
	Name      string
	Directed  bool
	Strict    bool
	Nodes     *Nodes
	Edges     *Edges
	SubGraphs *SubGraphs
	Relations *Relations
}

[Walter Schulze]

Can you show another screenshot picture where it has taken effect with the graphviz code as well? I would like to see what you are trying to achieve and I am not close to a computer.

…

On Sat, 21 Sep 2019 at 08:59, 唐盛军 ***@***.***> wrote: finally I have to add Global attribute to every Node by: for _, node := range(graph.Nodes.Nodes) { node.Attrs.Add("shape", "rect") node.Attrs.Add("style", "rounded") node.Attrs.Add("labelloc", "b") } if can support this grammer, that will be greate (by the way, it's pretty good now): node[shape=rect style=rounded labelloc=b] like： attrs := make(map[string]string) attrs["shape"] = "rect" attrs["style"] = "rounded" attrs["labelloc"] = "b" graph.AddNodeAttr(workflowName, attrs) type Graph struct { Attrs Attrs NodeAttrs Attrs //<== maybe need this one ? EdgeAttrs Attrs //<== same Name string Directed bool Strict bool Nodes *Nodes Edges *Edges SubGraphs *SubGraphs Relations *Relations } — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#55?email_source=notifications&email_token=AAN6YLLUXFAP3XAVRSM5KV3QKXH63A5CNFSM4IYR56JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IM3EQ#issuecomment-533777810>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN6YLLHZ7BEKZJMUDRJYHLQKXH63ANCNFSM4IYR56JA> .

[唐盛军]

sorry, I didn't use graphviz before,
I used Gographviz because my go project needed to generate a DAG flowchart, and I found this project.
simply say , i want this code:

graph.String()

can output the strings like this:

digraph tsjsdbd {
node[shape=box style=rounded labelloc=b]
"nodeA" -> "nodeB"
"nodeA"
"nodeB"
}

but now, i can only get output like this:

digraph tsjsdbd {
"nodeA" -> "nodeB"
"nodeA"  [shape=box style=rounded labelloc=b]
"nodeB"  [shape=box style=rounded labelloc=b]
}

[Walter Schulze]

Ah I see

This test passes

package gographviz

import (
	"testing"
	"strings"
)

// https://github.com/awalterschulze/gographviz/issues/32
func TestIssue55NodeAttrs(t *testing.T) {
	inputString := `
	digraph tsjsdbd {
		node[shape=box style=rounded labelloc=b]
		"nodeA" -> "nodeB"
		"nodeA"
		"nodeB"
		}
	`

	g, err := Read([]byte(inputString))
	if err != nil {
		t.Fatal(err)
	}

	s := `digraph tsjsdbd {
		"nodeA"->"nodeB";
		"nodeA" [ labelloc=b, shape=box, style=rounded ];
		"nodeB" [ labelloc=b, shape=box, style=rounded ];

	}`

	ss := strings.Join(strings.Fields(s), " ")
	gg := strings.Join(strings.Fields(g.String()), " ")
	if ss != gg {
		t.Fatalf("got <%s> want <%s>", ss, gg)
	}
	
}

[Walter Schulze]

When I look at the output version

https://dreampuf.github.io/GraphvizOnline/#digraph%20tsjsdbd%20%7B%0A%22nodeA%22%20-%3E%20%22nodeB%22%0A%22nodeA%22%20%20%5Bshape%3Dbox%20style%3Drounded%20labelloc%3Db%5D%0A%22nodeB%22%20%20%5Bshape%3Dbox%20style%3Drounded%20labelloc%3Db%5D%0A%7D

And your initial version

https://dreampuf.github.io/GraphvizOnline/#digraph%20tsjsdbd%20%7B%0Anode%5Bshape%3Dbox%20style%3Drounded%20labelloc%3Db%5D%0A%22nodeA%22%20-%3E%20%22nodeB%22%0A%22nodeA%22%0A%22nodeB%22%0A%7D

They look the same

[Walter Schulze]

So they are semantically equivalent.
This is a simplification that was decided to use during the design of this package.
https://github.com/awalterschulze/gographviz/blob/master/analyse.go#L69

If you want to really print out the same as the initial version
Maybe you could make Graph interface that dedups node attributes that are the same back into your more compact form.

[Walter Schulze]

Hope I have answered your question. Going to close this for now, but feel free to reopen.