Expose DOT-specific keywords

Question

Expose DOT-specific keywords

0xmichalis opened this issue 9 years ago · comments

A user shouldn't manually construct DOT keywords before adding them in the attributes of a graph object. All the names mentioned in here should be exposed by this package.

Walter Schulze · Answer 1 · Fri Mar 20 2015 14:32:30 GMT+0800 (China Standard Time)

I agree, it would be safer to have all the attributes so stringly typed.

We could make type safe and constrained methods to build the map[string]string and not break the current API.

This is quite a long list of things to implement and, unfortunately, I am currently very busy, but I would be open to contribution.
I am very sorry and I hope that this is an acceptable answer?

Michalis Kargakis · Answer 2 · Fri Mar 20 2015 18:30:27 GMT+0800 (China Standard Time)

Thanks for the answer! No worries, it's good that you agree about the issue. I might submit a PR if time permits it.:)

Walter Schulze · Answer 3 · Fri Mar 20 2015 19:47:07 GMT+0800 (China Standard Time)

I look forward to it :)

On 20 March 2015 at 12:30, Michail Kargakis notifications@github.com
wrote:

Thanks for the answer! No worries, it's good that you agree about the
issue. I might submit a PR if time permits it.:)

—
Reply to this email directly or view it on GitHub
#4 (comment)
.

Walter Schulze · Answer 4 · Sat Mar 25 2017 18:07:16 GMT+0800 (China Standard Time)

I have decided that we are going to make a breaking change to return some errors.
Or at least that is what this proposal is about
#23
Hopefully we can then fix this keyword problem as well.

Walter Schulze · Answer 5 · Mon Apr 10 2017 14:46:05 GMT+0800 (China Standard Time)

Merged pull request #25 with some attribute validation.