awalterschulze / gographviz

Parses the Graphviz DOT language in golang

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Escaping seems to be not complete

GoogleCodeExporter opened this issue · comments

While testing escaped graphs (NewEscape), I discovered that most probably in 
non-HTML strings all HTML (XML) control characters should be escaped. 

http://www.graphviz.org/doc/info/lang.html:

"In addition, the content must be legal XML, so that the special XML escape 
sequences for ", &, <, and > may be necessary in order to embed these 
characters in attribute values or raw text."

I've attached the patch.

Original issue reported on code.google.com by Smirnov....@gmail.com on 28 May 2014 at 8:44

Attachments:

Looks good, would you like some copyright?

Original comment by awalterschulze on 29 May 2014 at 6:33

Original comment by awalterschulze on 29 May 2014 at 6:44

  • Changed state: Accepted
No copyright, this is trivial change. Thanks!

Original comment by Smirnov....@gmail.com on 29 May 2014 at 12:36

This issue was closed by revision 454bc64fdfa2.

Original comment by awalterschulze on 30 May 2014 at 9:20

  • Changed state: Fixed
Thank you very much

Original comment by awalterschulze on 30 May 2014 at 9:20