How do I make it convert 20971520 to 20M?
meglio opened this issue · comments
I can't figure out, how do I convert 20 x 1024 x 1024 = 20971520 to 20M?
Whatever options I try, it is never 20M.
@meglio 8.0.0 changed the default base to 10, so in your case specify base: 2, or use 7.0.0.
filesize(20971520, {base: 2});
@avoidwork , please check - it outputs 21M, not 20M
please open a pr, you make the change you want to see. 🤷🏻♂️
What do you mean "the change I want to see"?
I'm basically reporting the issue with the website - it shows 21M instead of 20M despite me selecting "Unix mode". Is this expected? It seems like a bug in the website.
cool.
So could you fix the website please? It's a bit confusing when it renders something that's not expected as by the documentation.
why can't you fix the website? it's gh-pages branch.
Because I have not been contributing to this package as a coder and have no intention to do so. My contribution in this case is a detailed report of an issue and the time spent on explaining it here in Github Issues.
cool, i'll just roll it back then.
you just talked your fix out of existance. good luck with your contribution method in the future.
i'll explain ... just for clarity. i don't care about this issue. you don't care about this issue. so, there's no reason to "fix" the issue. if you cared, you'd contribute. the change you want to see happen is in response to change other people wanted to see, but those people put in the effort.
The only consequence of such an "educational" rollback is that I'll have to switch to another library, put yours in the "Avoid, toxic maintainer" list, and stop my contributions here as a tester who cared to put his time into reporting real issues. Thanks.
It's definitely not the expected result. I can't think out a reason why to change the default setting.
why does it matter? someone made the change, and didn't take away the ability for you to use base 2 if you choose. i literally can't understand anyone having a concern about this.