Not working with Bootstrap 3.2.0
CybMeta opened this issue · comments
I've tried carousel-swipe.js for bootstrap 3.1.1 and it works perfectly. As soon I update to Bootstrap 3.2.0 it stops working.
Thanks @CybMeta. Looking into it.
Great!! Waiting for news
@CybMeta Can't reproduce it. Works perfectly for me on Bootstrap 3.2. I tested also on Nexus 5 and iPhone 4. I've committed the testing page (example.html) that I've been using. Can you try it out?
I've been testing and finally I've made it to work with Bootstrap 3.2.0 by manually calling the carousel with javascript and don't relay in data- attributes. If you remove the manually carousel call from your example you will reproduce the issue. That was not necessary with Bootstrap 3.1.1. I don't know if this should be considered a issue or a requirement.
worked for me in Bootstrap 3.2, but needs to call it again at the page end.
$( ".carousel" ).carousel(});
I don't know why you have closed this issue. Bootstrap carousel can be used with data- attributes or with manual call, you choose, but your code force you to use one option killing the original Bootstrap behaviour.
@CybMeta I disagree. You don't need to "kill" the original Bootstrap behavior, but you need to extend it by manually invoking the carousel as described in the README.md file. It works according to the documentation so I don't see an issue there.
If your point is that it doesn't conform with the Bootstrap "data-" API philosophy - I agree. If you issue a PR I will gladly merge it in.
Uhhmmm.....now I agree with you. Thanks for the explanation.