Don't do the 0.18 -> 0.19 upgrade if `elm.json` already exists

Question

Don't do the 0.18 -> 0.19 upgrade if `elm.json` already exists

avh4 opened this issue 6 years ago · comments

Actually, it should probably move it to old-elm-package.json in case the user doesn't ahve version control.

The current behavior is that elm-package.json is left, but it is also strangely modified with some of the dependencies removed.

Qqwy / Marten · Answer 1 · Mon Sep 03 2018 03:10:45 GMT+0800 (China Standard Time)

One of the things it modifies is changing the source-directories back to ".".

Aaron VonderHaar · Answer 2 · Mon Sep 03 2018 07:12:29 GMT+0800 (China Standard Time)

Hmm... it looks like elm-upgrade already does this, but it seems like people then accidentally run Elm 0.18 commands which recreate it, or something like that.

Aaron VonderHaar · Answer 3 · Mon Sep 03 2018 10:47:03 GMT+0800 (China Standard Time)

Yeah, this seems to be caused by people running Elm 0.18 commands, which silently recreate the elm-package.json. However, elm-upgrade-0.19.3 will no longer attempt the 0.18 upgrade if an elm.json is found, so this will hopefully no longer confuse elm-upgrade users.