avehtari / BDA_course_Aalto

Bayesian Data Analysis course at Aalto

Home Page:https://avehtari.github.io/BDA_course_Aalto/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Clearly state the functions' arguments' names

AlejandroCatalina opened this issue · comments

There are cases where our test suite for markmyassignment checks the functions with some parameter names that must be present in the definition of the student, as in

p_identical_twin <- function(fraternal_prob=..., identical_prob=...) {}

If the student then names the function arguments using a different name R will raise an error, so we should just state cleary in the assignment pdf that they must use those same names.

Agree. Should probably check argument names for all functions in all tests.

Now fixed and in PR #47 .