bugs.idioms-reg-couples.TestCryptoLocker expects issue #41 to be present

Question

palant opened this issue 6 years ago · comments

https://github.com/avast-tl/retdec-regression-tests/blob/72243c8700bb3dcbf6ffc118180998fcae8e832b/bugs/idioms-reg-couples/test.py#L1669 asserts that function_40edd0 calls abort(). However, there is no such call in this function. The abort() call here is the result of avast/retdec#41, and fixing the issue (avast/retdec#391) makes the test fail. This assert should be removed.

Petr Zemek · Answer 1 · Thu Sep 13 2018 12:54:35 GMT+0800 (China Standard Time)

This is most probably an oversight and the check for abort() in function_40edd0 should be removed. Right @PeterMatula?

Wladimir Palant · Answer 2 · Thu Sep 13 2018 15:36:18 GMT+0800 (China Standard Time)

Alternatively, we could wait for avast/retdec#391 to be merged and negate that check - that abort() call should not be there.

Peter Matula · Answer 3 · Thu Sep 13 2018 15:41:26 GMT+0800 (China Standard Time)

It is very probable. I will look into this shortly (today/tomorrow).