Rename ILightCache Get and Set

Question

Rename ILightCache Get and Set

bruno-brant opened this issue 5 years ago · comments

Method names conflict with reserved keywords an results in a warning (CA1716).

Guilherme Luiz · Answer 1 · Sat Jan 25 2020 12:44:43 GMT+0800 (China Standard Time)

Do we really need synchronous versions of these methods? This smells like violation of ISP to me. If this interface were to be completely asynchronous, we could flawlessly implement its synchronous version.

Bruno Brant · Answer 2 · Thu Jan 30 2020 02:10:53 GMT+0800 (China Standard Time)

The methods have all been inherited from Redis implementation - that's the reason for the bad naming and the existence of both sync and async methods.

Worse part is that different SDK's in other platforms might use different names (although Redis' command kinda suggest the name).

In any case, I agree with you that the synchronous method is not required. We can remove it.

Priscila Silva · Answer 3 · Fri Apr 24 2020 22:57:48 GMT+0800 (China Standard Time)

Shoud we really remove it or just turn it as obsolete?

Bruno Brant · Answer 4 · Fri Apr 24 2020 23:02:26 GMT+0800 (China Standard Time)

@PriscilaAvanade correct, we should always mark obsolete before deleting. Also, look at #107 and #108; We should be obsoleting the whole of LightCache, but not before enabling our clients to use IDistributedCache.