at_color_parse() uses strtol(3) on each character

Question

at_color_parse() uses strtol(3) on each character

RalphCorderoy opened this issue 5 years ago · comments

https://github.com/autotrace/autotrace/blob/master/src/color.c#L42 shows a loop over each of six addresses of the hex characters in, for example, -background-color's argument, passing each address to strtol(3). This looks wrong. Either each character should contribute a value of 0-15 to c[i], or strtol() called once on the whole string.

Jürgen Weigert · Answer 1 · Sun Jun 23 2019 23:47:05 GMT+0800 (China Standard Time)

Thanks for spotting this, @RalphCorderoy !
would you say, PR #24 is a fix?

Ralph Corderoy · Answer 2 · Mon Jun 24 2019 15:34:37 GMT+0800 (China Standard Time)

Hi @jnweiger, Yes, that looks like it fixes the issue to me. Thanks.

Jürgen Weigert · Answer 3 · Mon Jun 24 2019 21:55:50 GMT+0800 (China Standard Time)

Thanks again for the review! closed fixed.