autotrace / autotrace

autotrace uses libming if found, but since Adobe killed the SWF format years ago and libming has been unmaintained for years and has hundreds of secutity issues filed against it, is there still any value in this or should it be removed?

What I also found strange was that there is no way to disable autotrace's SWF support:

autotrace/configure.ac

Lines 160 to 176 in cba2237

    
           HAVE_LIBSWF=no 
        
           AC_CHECK_HEADER(ming.h, 
        
           	        swf_header_found=yes, 
        
           		swf_header_found=no) 
        
           if test "${swf_header_found}" = yes ; then 
        
           	PKG_CHECK_MODULES([LIBSWF], 
        
           			  [libming], 
        
           			  [ 
        
           			   HAVE_LIBSWF=yes 
        
           			   AC_DEFINE(HAVE_LIBSWF,1,[Define to 1 if the SWF library is available]) 
        
           			   ], 
        
           			  ) 
        
           else 
        
           	AC_MSG_WARN([*** Cannot find ming.h.     ***]) 
        
           	AC_MSG_WARN([*** SWF output is disabled. ***]) 
        
           fi 
        
           AM_CONDITIONAL(HAVE_LIBSWF, test x$HAVE_LIBSWF = xyes)

It enables support if libming is found and does not provide a configure argument to turn it off, unlike libpng, ImageMagick, and pstoedit support which can each be disabled with a configure argument.

Yeah sounds like we should. Since it's an API-breaking change let's tag it as a future 0.40 version

	HAVE_LIBSWF=no
	AC_CHECK_HEADER(ming.h,
	swf_header_found=yes,
	swf_header_found=no)
	if test "${swf_header_found}" = yes ; then
	PKG_CHECK_MODULES([LIBSWF],
	[libming],
	[
	HAVE_LIBSWF=yes
	AC_DEFINE(HAVE_LIBSWF,1,[Define to 1 if the SWF library is available])
	],
	)
	else
	AC_MSG_WARN([* Cannot find ming.h. *])
	AC_MSG_WARN([* SWF output is disabled. *])
	fi
	AM_CONDITIONAL(HAVE_LIBSWF, test x$HAVE_LIBSWF = xyes)

Is it time to remove libming / SWF support?