Giters

auth0 / passport-wsfed-saml2

passport strategy for both WS-fed and SAML2 protocol

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Interested in discussing merging forks?

markstos opened this issue · comments

commented

Hello,

I'm in primary maintainer for passport-saml, which this project was forked from.

I'm not certain of what changes or incompatibilities were as part of the fork, but wanted to see if there's interest in discussing merging the projects.

The passport-saml project has been rather active lately, with bug fixes and feature patches flowing in from a number of contributors. It also has the most projects that depend on it and is the most downloaded SAML project for Node.

There's the saying "with enough eyeballs, all bugs are shallow". I think by joining efforts, we could end up with a higher quality product that either project might achieve alone. AuthO could benefit from being associated with Node's most highly visible SAML library.

If a merge were to happen, I would suggest it be hosted under the "auth0" namespace, as the developer hosting the current repo is no longer actively involved with the project.

You are welcome to contact me privately to continue the discussion or respond directly here as well.

Thanks.

commented

Hi, @markstos! Apologies for the delay. Indeed - with recent SAML exploits it may be wise to team up. A discussion would be great! I think a good first step would be to understand how far the packages have deviated and see what features each has.

commented

@machuga It look passport-saml was started in June, 2012, and this project forked it back in [August, 2012] (https://github.com/auth0/passport-wsfed-saml2/commits/master), just a few months later. However, a relatively small number of commits have added in this fork since then.

I see two kinds of useful comparisons, which should probably both be done:

  • Comparing the two "Release" pages to inventory diverging features.
  • Compare READMEs to see how compatible the interfaces remain.

From there we should have a sense if a merge makes sense. If we are lucky, we'll also discover some bug fixes that only exist in one project currently that could be shared.