auth0 / express-jwt

connect/express middleware that validates a JsonWebToken (JWT) and set the req.user with the attributes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove `@types/express-unless` from deps of `@types/express-jwt`

xinghul opened this issue · comments

Hello, I hit this error earlier:

error TS2688: Cannot find type definition file for 'express-unless'.
  The file is in the program because:
    Entry point for implicit type library 'express-unless'

I think there are two issues here:

  1. first of all, jwks-rsa listed @types/express-jwt as part of its dependencies, which is wrong IMO. (types definitions should be devDependencies instead, unless it's for another types definition.)
  2. starting from v2.0, @types/express-unless is just a stub types definition, express-unless comes with it's own typing, so @types/express-jwt should remove it from it's deps.

fixing no.2 should fix the issue.

Thank you, fixed in express-jwt@7.7.7