aurbano / robinhood-node

:chart_with_upwards_trend: NodeJS client for Robinhood Trading :fire:

Home Page:https://aurbano.github.io/robinhood-node

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`.d.ts` should not include `enum` declarations

prmichaelsen opened this issue · comments

I'm happy to fix this in a PR. But basically, to my knowledge, one should not define actual values in a Typescript d.ts file. They are not importable as values, only as types. Instead, one would declare
type Time: 'day' | 'immediate' and specify time as type of Time where it is used.

Please correct me if there is something I am missing. Otherwise, I will create the changes and a open a PR for this issue.

Makes sense @prmichaelsen, feel free to send a PR!