frames.js - crc skip/check at wrong offset

Question

frames.js - crc skip/check at wrong offset

showstopper opened this issue 13 years ago · comments

Refering to https://github.com/ofmlabs/jsmad/blob/master/src/frame.js#L111

Specs says that the 16-bit crc comes after the frame header. Therefore the skip should be located at https://github.com/ofmlabs/jsmad/blob/master/src/frame.js#L172.

Amos Wenger (old) · Answer 1 · Sun Dec 25 2011 01:34:11 GMT+0800 (China Standard Time)

So... test case + patch? :)

As you can see, jsmad (possibly libmad too) skips the crc check anyway, and it's skipped somewhere so it possibly doesn't corrupt decoding that much.

showstopper · Answer 2 · Sun Dec 25 2011 03:04:14 GMT+0800 (China Standard Time)

@nddrylliog Actually, if I understood this correctly, the rest of the header decoding is completely flawed if crc-protection is on. (Correct me if I'm wrong). I'll add test-patch later this evening (currently busy with exchanging presents and stuff)