Remove protoc build dependency
senekor opened this issue · comments
Hi, I noticed you're using protoc in your build, which makes many aspects of the build more complicated (nix, Dockerfile, cross, github workflows...) But more importantly, users cannot easily cargo install from source anymore. There is a pure-rust protobuf compiler implementation called protox, which can be used as a library in the build script of atuin-daemon. I have a working version of this locally.
My question is, are you aware of protox and did you already decide to not use it for some reason?
Otherwise, if you have no objections, I'll prepare a PR with the simplified build.
To add to this, it seems the protoc dependency might be causing the update to v18.3.0 to fail:
This is after I installed the protobuf-compiler package on my distribution. Without it, I get the following error instead:
This is on Fedora 40 btw, if that means anything. Rust compiler version is v1.78.0
My question is, are you aware of protox and did you already decide to not use it for some reason?
At the time I wasn't confident in its maturity, but it does seem good. Would love a PR
@OlaoluwaM see #2113