Giters

att / vfd

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add VF with multiple mac addresses is failing in nic_agnostic branch

ScottDaniels opened this issue · comments

commented

When an attempt to add a VF with multiple MAC addresses is made, it is rejected.

commented

The check to ensure that a pf/vf combination exists in the configuration was causing this to fail. The configuration file validation was invoking can_add_mac() which expected the vf/pf combination to exist in the config, but the call was being made prior to the VF being added.

The can_add_mac() function was changed to skip this check if a VF number < 0 is passed in; it is the responsibility of the configuration vetting function to ensure that the total number of MACs being attempted are less than the maximum number for any VF. The can_add_mac() function still validates the overall total for all VFs currently configured plus the additional MAC.

This is fixed in commit: f915388; closing.