Chore: Imports used by some at_widget packages are depreciated

Question

Chore: Imports used by some at_widget packages are depreciated

CurtlyCritchlow opened this issue 24 days ago · comments

Describe the bug

The below warning messages appears on the following packages when using the dependency overrides for at_client_mobile:

dependency_overrides:
  at_client_mobile:
    git:
      url: https://github.com/atsign-foundation/at_client_sdk.git
      path: packages/at_client_mobile
      ref: expose_backupkey-constants

Warning Messages:

at_invitation_flutter

Analyzing at_invitation_flutter...                                      

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService • example/lib/main.dart:36:3 •
          deprecated_member_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          example/lib/second_screen.dart:20:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • example/lib/second_screen.dart:20:3 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/invitation_service.dart:65:18 •
       deprecated_export_use

at_follows_flutter

Analyzing at_follows_flutter...                                        ⣾

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService • lib/screens/connections.dart:21:9
          • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/screens/connections.dart:21:9 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:25:24 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:25:24 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated
       • lib/services/sdk_service.dart:35:18 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/utils/at_follow_services.dart:16:7 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/utils/at_follow_services.dart:16:7 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:290:8 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:290:8
       • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:292:3 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:292:3
       • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          test/unit_tests/connections_service_test.dart:292:37 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • test/unit_tests/connections_service_test.dart:292:37
       • deprecated_export_use

at_location_flutter

Analyzing at_location_flutter...                                        

   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/second_screen.dart:22:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       example/lib/second_screen.dart:22:3 • deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated •
       lib/service/at_location_notification_listener.dart:75:18 • deprecated_export_use

at_login_flutter

Analyzing at_login_flutter
                         
   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/main.dart:35:3 • deprecated_member_use
warning • The ability to import 'KeychainUtil' indirectly is deprecated •
       lib/services/at_login_service.dart:197:29 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          lib/widgets/at_login_widget.dart:35:30 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       lib/widgets/at_login_widget.dart:35:30 • deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          lib/widgets/at_login_widget.dart:100:30 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated •
       lib/widgets/at_login_widget.dart:100:30 • deprecated_export_use

at_onboarding_flutter

Analyzing at_onboarding_flutter...                                      

   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:24:16 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:24:16 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:25:17 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:25:17 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:68:3 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:68:3 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:72:5 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:72:5 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:72:31 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:72:31 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:94:5 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:94:5 •
       deprecated_export_use
   info • 'onboard' is deprecated and shouldn't be used. Use
          AtAuthService.onboard method •
          lib/services/onboarding_service.dart:96:49 •
          deprecated_member_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/onboarding_service.dart:128:7 •
          deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/onboarding_service.dart:128:7 •
       deprecated_export_use
   info • 'authenticate' is deprecated and shouldn't be used. Use
          AtAuthService.authenticate method •
          lib/services/onboarding_service.dart:133:52 •
          deprecated_member_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:157:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:162:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:167:12 •
       deprecated_export_use
warning • The ability to import 'KeychainUtil' indirectly is
       deprecated • lib/services/onboarding_service.dart:172:41 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:6:16 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:6:16 •
       deprecated_export_use
   info • 'AtClientService' is deprecated and shouldn't be used. Use
          AtClientMobile.authService •
          lib/services/sdk_service.dart:7:17 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is
       deprecated • lib/services/sdk_service.dart:7:17 •
       deprecated_export_use

at_theme_flutter

Analyzing at_theme_flutter...                                           

   info • 'AtClientService' is deprecated and shouldn't be used. Use AtClientMobile.authService •
          example/lib/main.dart:40:3 • deprecated_member_use
warning • The ability to import 'AtClientService' indirectly is deprecated • example/lib/main.dart:40:3 •
       deprecated_export_use
warning • The asset file '.env' doesn't exist • example/pubspec.yaml:68:7 • asset_does_not_exist

Steps to reproduce

First I added the below dependency_overide to the pubspec.yaml file of the at_widget packages if they have at_client_mobile as a dependency.

dependency_overrides:
  at_client_mobile:
    git:
      url: https://github.com/atsign-foundation/at_client_sdk.git
      path: packages/at_client_mobile
      ref: expose_backupkey-constants

Then I run flutter analyze in the teminal.

Expected behavior

They should be no info or warning messages about depreciated classes being imported directly.

Screenshots

No response

Smartphones

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Were you using an atApplication when the bug was found?

at_theme_flutter, at_onboarding_flutter, at_login_flutter, at_location_flutter, at_follows_flutter, at_invitation_flutter

Additional context

No response

Sitaram Pavan Kumar Kalluri · Answer 1 · Thu Jun 27 2024 10:49:48 GMT+0800 (China Standard Time)

@CurtlyCritchlow : The lint issues and above mentioned packages are fixed. Please find the changes in the following commit: atsign-foundation/at_widgets@32e396f

Curtly Critchlow · Answer 2 · Thu Jun 27 2024 20:09:40 GMT+0800 (China Standard Time)

@sitaram-kalluri, I double check with flutter analyze and the issues have been resolved. Thanks