atsign-foundation / at_client_sdk

The Dart implementation of atSDK used for implementing Atsign's technology into other software

Home Page:https://pub.dev/publishers/atsign.org/packages

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

APKAM - replace saving atKeys file for new enrollment apps with keychain storage

murali-shris opened this issue · comments

Is your feature request related to a problem? Please describe.

  • newly enrolled APKAM apps currently are required to save .atKeys file
  • save the data in keychain to avoid overhead of maintaining .atKeys file for newly enrolled clients
  • only the first onboarding client/app should save .atKeys file(existing logic. no change required)
  • if newly enrolled app is uninstalled or device is lost, user has to enroll the app again

Describe the solution you'd like

  • appName/deviceName info has to be saved in keychain along with existing info we store
  • _storeToKeyChainManager(..) logic has to be called for newly enrolled client in AtAuthServiceImpl
  • newly enrolled app will read atKeys info from keychain for pkam auth.
  • Store and retrieve methods from keychain should reusable for client onboarded without apkam and enrolled with apkam.

Describe alternatives you've considered

No response

Additional context

No response

Pull request under review.
#1295

The changes are completed and are merged to trunk. Hence closing the ticket.