Cleanup of test code

[Ethan Brockmann]

We have really strong test coverage, but the tests have gotten a little messy in places. I think there's some cleanup we can do.

#200 (comment)

#200 (comment)

Please add links to other comments as needed for specific issues noticed!

[Ethan Brockmann]

#200 (comment)

[André Veríssimo]

One more :-)

diff --git a/R/metadata.R b/R/metadata.R
index bf24ecd..645acc4 100644
--- a/R/metadata.R
+++ b/R/metadata.R
@@ -32,14 +32,12 @@
 #'
 #' xportr_metadata(adlb, metadata, "test")
 #'
-#' if (rlang::is_installed("magrittr")) {
-#'   library(magrittr)
-#'
-#'   adlb %>%
-#'     xportr_metadata(metadata, "test") %>%
-#'     xportr_type() %>%
-#'     xportr_order()
-#' }
+#' library(magrittr)
+#'
+#' adlb %>%
+#'   xportr_metadata(metadata, "test") %>%
+#'   xportr_type() %>%
+#'   xportr_order()

[Ben Straub]

• Look into suppresswarnings
• Organization of the test code (bonus-time)
• Subject headings for test - what is it testing and is it described in a nice and clear way

Cross-check with what Andre is doing here: #219