`get_meta_result()` and `get_meta_subset()` should gracefully error with invalid ellipsis params

Question

`get_meta_result()` and `get_meta_subset()` should gracefully error with invalid ellipsis params

mstackhouse opened this issue 2 years ago · comments

Michael Stackhouse commented 2 years ago

t <- tplyr_table(adsl, TRT01P) %>% 
  add_layer(
    group_count(AGEGR1, by = vars("Age Group by Sex n (%)", SEX))
  ) 

dat <- t %>% 
  build(metadata=TRUE)

get_meta_result(t, "c1_1", "var1_Placebo", "var1_Xanomeline High Dose")

Michael Stackhouse · Answer 1 · Thu Oct 27 2022 00:03:06 GMT+0800 (China Standard Time)

This should throw an error because of invalid ellipsis content, but instead the ellipsis is just discarded and no error is encountered.

Andrew Bates · Answer 2 · Sat Dec 16 2023 01:05:28 GMT+0800 (China Standard Time)

@mstackhouse Should this be an error or a warning? I would think warning because it's not wrong per se but they should know the dots are ignored.

Michael Stackhouse · Answer 3 · Sat Dec 16 2023 01:31:17 GMT+0800 (China Standard Time)

I lean towards error because the syntax is technically wrong. If the syntax is right but the behavior is potentially unexpected, I'd want to warn - but there's not a reason you should leave the invalid syntax so I just want refuse to let the action happen. Does that make sense?