atomist-attic / rug

DEPRECATED Runtime for Rugs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rug does not consider a message properly handles an error

ddgenome opened this issue · comments

If your onError is a response handler, rug considers the error handled and does not create its own error message.

If your onError is a message, rug does not consider the error handled and sends its own message, in addition to your message. The issue is returning Nil here:

https://github.com/atomist/rug/blob/d777322ccbdb7f6190e30a56a0c73c4710d61155/src/main/scala/com/atomist/rug/runtime/plans/LocalPlanRunner.scala#L110

Looking into this a bit more, it may be best to require it to be handled by a handler. That way at least an error message can be conveyed.