atomist-attic / rug

DEPRECATED Runtime for Rugs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove `label?` from Presentable instruction used by DirectedMessage and ResponseMessage

tanya-coding opened this issue · comments

Label is no longer used to specify button text and it's rendered directly by handler so having label property only adds confusion. Label is still being used by LifecycleMessage.

@kipz here are we mostly concerned with TS API or is the goal to remove label from some scala classes as well? My preference would be to avoid introducing new types in scala as we eventually migrate lifecycle messages to new model where label is no longer needed and would be able to simply remove it from all types.

TS API - under the hood, it's all the same scala class.

Fixed in master