What happened to the colours?
Fequois opened this issue · comments
The screenshots show beautiful, fizzy colours! They were perhaps a bit too bright for some, but I think over the last few months the One Dark combination has become a little gloomy.
So, since I know about nothing on this subject: is it possible to give the One Dark theme an option to inject a little bright, bold happiness into the syntax? Or do I need to fork this repo and make the changes?
tl;dr: Can a UI theme control/affect syntax themes in any way?
Apologies if this issue is inappropriate (because it really isn't an issue, more of a question).
This is essentially a duplicate of #23. Please see that comment thread for more details. There is a branch (albeit slightly outdated) called sm-high-contrast that retains the high contrast seen in the marketing screenshots, so you can clone this repo, checkout that branch and be a (somewhat) happy camper.
I believe there were some suggestion by @simurai in the thread for adding a "high contrast" configuration option to the theme, but not sure what came of that (if I even remember correctly).
Since this is essentially a duplicate and was discussed to death in the aforementioned issue, I'm closing this. If you strongly disagree, feel free to re-open, but we won't bump the contrast (again) outside of introducing an option.
adding a "high contrast" configuration option to the theme
Ya, that was my hope, but I haven't found a good way to do it. Some themes override variables on disk, but there are issues with not reloading all the styles.
Maybe I'll just publish the sm-high-contrast branch as another theme. Keeping it updated with the core theme shouldn't be too much of a burden.
@Fequois Ok, it's now its own theme.. dark-vivid! https://atom.io/themes/one-dark-vivid-syntax
Oh. I like that.
Thanks so much @simurai!