`FindCredentials` call on Linux without unlocking the key store crashes
jsimonet opened this issue · comments
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Some prerequisites are not applicable since I did not used Atom to develop the fix and check for testing.
Description
FindCredentials call on Linux without unlocking the key store crashes.
(process:280213): libsecret-CRITICAL **: 16:09:20.426: secret_value_get_text: assertion 'value' failed
Steps to Reproduce
- Ensure the key store is locked
- call
FindCredentials - Click on "Cancel" when password is asked for unlocking the keystore
Expected behavior:
A crash does not happens.
Actual behavior:
A crash does happens.
Reproduces how often:
100% of the time.
Versions
Not using Atom for testing, using another Electron application.
Linux Manjaro Release: 22.0.0.