atom / language-xml

XML package for Atom

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue with syntax coloring/leading spaces

pgkos opened this issue · comments

commented

There is a small issue with syntax coloring which I have observed in XML files (I am not sure if it occurs with other syntaxes). I think the issue did not occur in previous versions of Atom.
xml_coloring_bug
As you can see, the color spans are moved by one character forward on the lines which only contain an XML attribute. The issue occurs only if the number of leading spaces on these lines is even.
(Atom 0.207.0, Ubuntu 14.04 64-bit)

@pgkos Strange, I'm not seeing that behavior on the latest master version of Atom:

screen shot 2015-06-11 at 12 28 58

Do you see the same problem in Atom 0.208.0 and in safe mode?

Also, can you take that screenshot again, but with the invisible characters turned on? Go to Settings and turn on "Show invisibles".

commented

I have taken this screenshot in safe mode, the issue still occurs:
xml_coloring_bug_2
I can confirm that the same issue also occurs in Atom 0.206.0 on Ubuntu (different computer), but on Mac OS X 10.10 everything is fine.

Thanks for checking.

That's strange -- I was able to reproduce this in 0.206.0 on Ubuntu, but not on 0.208.0. Can you please confirm that you are running 0.208.0 (in your last message you mentioned that you tried 0.206.0)?

commented

Yes, I am running Atom 0.208.0 on one of the computers, and 0.206.0 on other.

I just did a complete purge/reinstall of Atom 0.208.0 on an Ubuntu computer and the XML issue doesn't occur anymore. (I also tried removing the ~/.atom directory but it didn't solve the issue)

Out of curiosity, I did a diff of /opt/atom directories (one before and one after reinstall) and it seems that the following files/packages/directories are not properly updated while installing/updating Atom on Ubuntu (I am installing/updating atom via Ubuntu ppa):

/opt/atom/resources/app.asar

and also

/opt/atom/resources/app/apm/node_modules/yargs/node_modules/cliui/node_modules/center-align/
/opt/atom/resources/app/apm/node_modules/yargs/node_modules/cliui/node_modules/right-align/
/opt/atom/resources/app/apm/node_modules/first-mate/node_modules/grim/node_modules/coffeestack/node_modules/source-map/node_modules/amdefine/
/opt/atom/resources/app/apm/node_modules/first-mate/node_modules/oniguruma/
/opt/atom/resources/app/apm/node_modules/git-utils/
/opt/atom/resources/app/apm/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/
/opt/atom/resources/app/apm/node_modules/plist/package.json

so, this is probably an issue with ppa/apt.

Glad to hear that reinstalling fixed your issue, @pgkos. As for the PPA issue, you may want to report that to Webupd8.