CI not passing (xvfb config needs to be updated)

[DeeDeeG]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Travis CI runs fail with this error:

The command "export DISPLAY=:99.0; sh -e /etc/init.d/xvfb start" failed and exited with 127 during .

This is because the CI config is setting up xvfb in a way that only works on the Trusty Travis CI image.

before_script:
  - export DISPLAY=:99.0; sh -e /etc/init.d/xvfb start

Travis CI docs for setting up xvfb: https://docs.travis-ci.com/user/gui-and-headless-browsers#using-xvfb-to-run-tests-that-require-a-gui

The config should set dist: trusty to pin CI runs to a Trusty environment, or even better, use the config that is compatible with Travis CI's Xenial and newer images:

services:
  - xvfb

Steps to Reproduce

1. Run Travis CI for this repository

Expected behavior:

With nothing having changed on master branch, this repo's CI should pass today just as much as it did when it was last run, in September 2018.

Actual behavior:

CI fails, due to updated default Travis CI environment (Xenial) requiring updated xvfb config.

Reproduces how often:

100% of the time.

Versions

master branch of this repository is affected.

Additional Information

I will post a PR to fix this. I prefer the "use Xenial/newer with proper configs" solution, rather than the "pin CI to Trusty" solution, personally.