git-diff stopped working

Question

git-diff stopped working

rm-code opened this issue 9 years ago · comments

Using Atom 0.194.0 under OSX 10.10.3 with only the minimap and minimap-git-diff package. As you can see there are no differences shown in the minimap and the minimap preference menu has a strange empty bar below the git-diff entry.

Cédric Néhémie · Answer 1 · Thu Apr 30 2015 19:48:11 GMT+0800 (China Standard Time)

Thanks for the report, but can you give me some details like the version of the minimap and minimap-git-diff packages? I'm using it every day and didn't had any issue with it since some time now.

Robert · Answer 2 · Thu Apr 30 2015 19:55:42 GMT+0800 (China Standard Time)

Totally forgot about the plugin versions! Here you go:

minimap 4.7.6
minimap-git-diff 4.1.2

It has been working for me too for the past few days. I don't know when and why it stopped working, but I deactivated all 3rd party plugins to make sure it wasn't a conflict with another package.

Robert · Answer 3 · Thu Apr 30 2015 20:09:40 GMT+0800 (China Standard Time)

Okay ... I just opened Atom in dev mode, closed it and restarted and now git-diff is working perfectly normal.

Robert · Answer 4 · Thu Apr 30 2015 20:20:34 GMT+0800 (China Standard Time)

I can't reproduce the issue now. I guess this can be closed then.

(Sorry for the false alarm)

Cédric Néhémie · Answer 5 · Thu Apr 30 2015 20:24:58 GMT+0800 (China Standard Time)

Ok, thanks for the feedback, not sure why you didn't see anything at first. If you get that again I'll be curious to know if the gutter's git diff markers are there or not.

As for the menu styling, I believe the rule for the separator height isn't specific enough. Can you try something for me in your user stylesheet:

First:

minimap-quick-settings ol.list-group li.separator {
  height: 1px;
}

If it doesn't change the height please try this:

minimap-quick-settings .select-list ol.list-group li.separator {
  height: 1px;
}

I'll need to make sure what specificity to use in the stylesheet to override your theme default.

Robert · Answer 6 · Thu Apr 30 2015 20:32:49 GMT+0800 (China Standard Time)

If you get that again I'll be curious to know if the gutter's git diff markers are there or not.

The markers in the gutter were visible.

Can you try something for me in your user stylesheet:

The first one works fine for me.

Matthias Dietrich · Answer 7 · Tue May 05 2015 16:57:50 GMT+0800 (China Standard Time)

Having a similar issue as @rm-code had but I'm able to reproduce this, even after a restart. For me, the minimap doesn't show any difference for changed, added or deleted lines. Gutters are visible.

Plugin versions:

minimap 4.8.0
minimap-git-diff 4.1.2

What more information can I provide?

Matthias Dietrich · Answer 8 · Wed May 06 2015 18:27:43 GMT+0800 (China Standard Time)

Weird. A day later and it's working, even though I didn't restart Atom. But what I did is switching to a new project using the project-manager plugin and closing the previous project. Now in the new project everything is working fine.