atom-minimap / minimap-git-diff

A minimap binding for the atom git-diff package

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

suggestion to make color fade out more

dragonxlwang opened this issue · comments

In dark themes, when using search with highlight in minimap, the git colors interferes with the search highlighted result. I found by setting minimap-git-diff colors fade out more, this situation becomes much better.


.minimap {
  .git-line-modified{
    background: fadeOut(@syntax-color-modified, 50%);
  }

  .git-line-added {
    background: fadeOut(@syntax-color-added, 40%);
  }

  .git-line-removed {
    background: fadeOut(@syntax-color-removed, 30%);
  }
}

I changed them to 80% 70% and 60% respectively in my ~/.atom/style.less. (although change them to all 80% will do the trick as well).

In sublime the lines get just a bit highlighted on the left side (like a border)
I think this is more pealing as you can see the color more clear behind it. but i don't know how to do it like sublime

screen shot 2016-04-11 at 09 57 15

Edit: found out how :D

atom-text-editor::shadow {
  atom-text-editor-minimap::shadow canvas:first-child {
    left: -99%;
  }
}

screen shot 2016-04-12 at 14 39 19

@jimmywarting I think I'll add a new decoration type to support that effect, because the way you're doing it you are also squeezing every other decorations that are displayed on this canvas (if you have other plugins that create background decorations)

Oh... darn

@jimmywarting If you have minimap@4.22.0 and minimap-git-diff@4.3.0 you'll be able to change the decoration type in the minimap-git-diff settings.

@dragonxlwang That's what user stylesheet is here for 😅, so I'll close the issue as there's no way to please everyone tastes with defaults.