Giters

atom-minimap / minimap-git-diff

A minimap binding for the atom git-diff package

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Uncaught TypeError: Cannot read property 'getTextEditor' of null

jldavis76 opened this issue · comments

commented

[Enter steps to reproduce below:]

  1. Recently (just prior) updated the minimap plug-in
  2. Changed Theme from Seti to Atom Material
  3. Chose "Add a Project Folder" from the menu bar.

Atom Version: 1.0.2
System: Mac OS X 10.10.3
Thrown From: minimap-git-diff package, v4.1.5

Stack Trace

Uncaught TypeError: Cannot read property 'getTextEditor' of null

At /Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:10

TypeError: Cannot read property 'getTextEditor' of null
  at new MinimapGitDiffBinding (/Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:10:23)
  at /Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:7:3
  at /Users/JoelDavis/.atom/packages/minimap/lib/main.coffee:265:44
  at Map.forEach (native)
  at Main.observeMinimaps (/Users/JoelDavis/.atom/packages/minimap/lib/main.coffee:265:23)
  at MinimapGitDiff.createBindings (/Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:62:30)
  at MinimapGitDiff.createBindings (/Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:1:1)
  at /Users/JoelDavis/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:53:5
  at Emitter.module.exports.Emitter.emit (/Users/JoelDavis/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at Project.module.exports.Project.addPath (/Users/JoelDavis/Downloads/Atom.app/Contents/Resources/app.asar/src/project.js:274:29)
  at /Users/JoelDavis/Downloads/Atom.app/Contents/Resources/app.asar/src/atom.js:880:41
  at EventEmitter.<anonymous> (/Users/JoelDavis/Downloads/Atom.app/Contents/Resources/app.asar/src/atom.js:416:16)
  at emitOne (events.js:77:13)
  at EventEmitter.emit (events.js:166:7)

Commands

     -1:34.7.0 deprecation-cop:view (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-seti-syntax.theme-seti-ui)
     -0:06.5.0 application:add-project-folder (select.form-control)

Config

{
  "core": {
    "themes": [
      "atom-material-ui",
      "seti-syntax"
    ],
    "disabledPackages": [
      "git-diff",
      "go-to-line",
      "image-view",
      "language-javascript",
      "open-on-github",
      "linter-csslint"
    ],
    "audioBeep": false
  }
}

Installed Packages

# User
atom-alignment, v0.12.1
atom-autocomplete-php, v0.4.3
atom-material-ui, v0.5.1
autocomplete-php, v0.3.6
color-picker, v2.0.9
editor-stats, v0.17.0
jsformat, v0.9.0
jshint, v1.3.9
language-javascript-semantic, v0.2.1
linter, v1.2.3
linter-jshint, v1.0.0
linter-jsonlint, v0.1.4
linter-php, v0.0.15
minimap, v4.11.2
minimap-git-diff, v4.1.5
pigments, v0.8.4
seti-syntax, v0.4.0
terminal-status, v1.6.8

# Dev
No dev packages
commented

Hmm, not sure about the cause for that, do you still have this error after reloading Atom?

commented

It only occurred that first time. I have since added project folders with no error message.

commented

Ok, looks like a random error induced by the package update, I'll add a guard with a console warning so that the error won't tigger again, but it's just a workaround so that means I'll have to dig deeper if I want to fix this definitely.

commented

Sounds good. Hope this helped!