Uncaught Error: Repository has been destroyed
olegshilov opened this issue · comments
[Enter steps to reproduce below:]
- ...
- ...
Atom Version: 1.0.0
System: Mac OS X 10.10.3
Thrown From: minimap-git-diff package, v4.1.3
Stack Trace
Uncaught Error: Repository has been destroyed
At /Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/git-repository.js:382
Error: Repository has been destroyed
at GitRepository.module.exports.GitRepository.getRepo (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/git-repository.js:382:15)
at GitRepository.module.exports.GitRepository.getLineDiffs (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/src/git-repository.js:297:19)
at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.getDiffs (/Users/olegshilov/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:72:62)
at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.updateDiffs (/Users/olegshilov/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:34:33)
at /Users/olegshilov/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:1:1
at Emitter.module.exports.Emitter.emit (/Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
at /Users/olegshilov/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1183:25
Commands
5x -2:22.4.0 core:select-left (atom-text-editor.editor.is-focused)
-2:20.1.0 core:delete (atom-text-editor.editor.is-focused)
-2:18.5.0 emmet:toggle-comment (atom-text-editor.editor.is-focused)
-2:17.6.0 core:move-up (atom-text-editor.editor.is-focused)
-2:17.4.0 core:move-right (atom-text-editor.editor.is-focused)
-2:13.2.0 core:save (atom-text-editor.editor.is-focused)
-2:09.7.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
2x -2:09.6.0 core:move-left (atom-text-editor.editor.is-focused)
-2:08.6.0 core:save (atom-text-editor.editor.is-focused)
-1:41.5.0 core:move-up (atom-text-editor.editor.is-focused)
2x -1:41.2.0 core:move-down (atom-text-editor.editor.is-focused)
-1:38.8.0 core:save (atom-text-editor.editor.is-focused)
-0:04.7.0 core:move-right (atom-text-editor.editor.is-focused)
-0:04.3.0 core:select-up (atom-text-editor.editor.is-focused)
-0:03.7.0 core:delete (atom-text-editor.editor.is-focused)
-0:02.3.0 core:move-down (atom-text-editor.editor.is-focused)
Config
{
"core": {}
}Installed Packages
# User
atom-beautify, v0.28.7
color-picker, v2.0.7
emmet, v2.3.10
file-icons, v1.5.8
language-javascript-jsx, v0.3.6
linter, v1.0.6
linter-coffeelint, v0.3.2
linter-csslint, v0.0.13
linter-eslint, v1.0.8
minimap, v4.10.0
minimap-git-diff, v4.1.3
minimap-pigments, v0.1.1
pigments, v0.8.0
# Dev
No dev packages
Thanks for the report, looks like I forgot to listen to the destruction of the repo object.
Could you please fix it?
Fixed in v4.1.4
Still have the issue in 4.1.7
Atom Version: 1.0.7
System: Ubuntu 14.04.3
Thrown From: minimap-git-diff package, v4.1.7
Stack Trace
Uncaught Error: Repository has been destroyed
At /opt/atom/resources/app.asar/src/git-repository.js:382
Error: Repository has been destroyed
at GitRepository.module.exports.GitRepository.getRepo (/opt/atom/resources/app.asar/src/git-repository.js:382:15)
at GitRepository.module.exports.GitRepository.getLineDiffs (/opt/atom/resources/app.asar/src/git-repository.js:297:19)
at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.getDiffs (/home/freon/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:80:62)
at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.updateDiffs (/home/freon/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:41:33)
at Immediate._onImmediate (/home/freon/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:1:1)
at processImmediate [as _immediateCallback] (timers.js:369:17)
Commands
-1:58.9.0 ctrl-last-tab:next (atom-text-editor.editor.is-focused)
-1:56.5.0 tidy-tabs:remove-stale-tabs (atom-text-editor.editor.is-focused)
-1:46.4.0 core:backspace (atom-text-editor.editor.is-focused)
-1:45.7.0 core:save (atom-text-editor.editor.is-focused.autocomplete-active)
-1:43.5.0 atomatigit:toggle (atom-text-editor.editor.is-focused)
-1:40.4.0 atomatigit:stage (div.file-list-view.list-view)
-1:39.3.0 atomatigit:commit (div.file-list-view.list-view)
-1:37.1.0 core:backspace (atom-text-editor.editor.is-focused.autocomplete-active)
-1:34.4.0 core:save (atom-text-editor.editor.is-focused)
2x -1:31.4.0 atomatigit:toggle (atom-text-editor.editor.is-focused)
-1:21.3.0 settings-view:open (atom-text-editor.editor.is-focused)
-1:09.4.0 release-notes:show (div.settings-view.pane-item)
-0:44.2.0 core:close (div.release-notes.padded.pane-item.native-key-bindings)
-0:16.9.0 settings-view:open (atom-text-editor.editor.is-focused)
-0:14.3.0 core:select-all (atom-text-editor.editor.mini.is-focused)
3x -0:02.6.0 ctrl-last-tab:next (div.settings-view.pane-item)
Config
{
"core": {
"followSymlinks": true,
"disabledPackages": [
"symbols-view",
"jsformat",
"atom-ctags",
"duplicate-line-or-selection",
"atom-ternjs",
"autocomplete-hack",
"git-plus"
],
"projectHome": "/home/www",
"themes": [
"atom-dark-ui",
"atom-dark-syntax"
],
"autoHideMenuBar": true
}
}Installed Packages
# User
Atom-Syntax-highlighting-for-Sass, v0.5.0
atom-beautify, v0.28.11
atomatigit, v1.5.4
autocomplete-paths, v1.0.2
color-picker, v2.0.11
ctrl-last-tab, v0.2.0
docblockr, v0.7.3
git-diff, v0.55.0
highlight-selected, v0.10.1
language-cmake, v0.1.4
language-cpp14, v0.3.0
language-diff, v0.3.1
language-docker, v1.1.3
language-ini, v1.11.0
linter, v1.4.1
local-history, v3.2.3
minimap, v4.12.3
minimap-git-diff, v4.1.7
minimap-highlight-selected, v4.3.0
minimap-selection, v4.3.0
pigments, v0.11.0
pretty-json, v0.4.1
project-manager, v1.15.11
svn, v0.0.8
tab-numbers, v0.3.0
tabs-to-spaces, v0.11.0
tidy-tabs, v0.2.0
tree-view-git-projects, v0.5.0
# Dev
No dev packages@MindFreeze it should be fixed in v4.1.8, looks there was still some racing conditions when reading the diffs;
Confirmed. v4.1.8 works!