atmos / heaven

:walking: Rails app for GitHub Flow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support generic REDIS_URL

ajsharma opened this issue · comments

Redis services other than openredis have other ENV vars (I'm using Heroku's Redis Cloud add-on which provides REDISCLOUD_URL), it would be nice to have a generic REDIS_URL fallback for the other options.

I'm always kind of in favor of the free version unless you know what you're doing.

Me too :) , but openredis's micro isn't free anymore on Heroku
screen shot 2014-07-09 at 10 05 47 am

Redis To Go and Redis Cloud do offer free tiers, which is why I'm using Redis Cloud.

So why doesn't heroku set this?

I like what Sidekiq does for this.

If you've set REDIS_PROVIDER, it will use ENV[ENV["REDIS_PROVIDER"]] to
get the URL. So you'd do REDIS_PROVIDER=OPENREDIS_URL, or
REDIS_PROVIDER=REDIS_URL, or whatever.

On Wed, Jul 9, 2014 at 5:29 PM, Corey Donohoe notifications@github.com
wrote:

So why doesn't heroku set this?


Reply to this email directly or view it on GitHub
#51 (comment).

@atmos I'm not sure what you mean by your last comment.

@foca I like that idea too (better than mine)

PRs welcome. I'll definitely apply it though.

@foca @atmos thanks so much! Gonna try it out today 👍