atifaziz / NCrontab

Crontab for .NET

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make obvious in code/documentation that cron timing is better with UTC

Miggleness opened this issue ยท comments

I think there is value in being upfront that scheduling with cron is based on UTC, and not local time.

  1. Update documentation
  2. Update 'cron' arguments with 'cronUtc'

I can take this up granted the @atifaziz does have free time to take up PRs ๐Ÿ˜€

I agree with #๏ปฟ1 but I'm less sure about the value of #๏ปฟ2. The documentation should just highlight the issue, that assuming local time can cause surprises like a schedule being potentially skipped when the clock moves back.

I welcome a PR for this (thanks for the offer) and I'll find the time to review as long as you don't hold me to a deadline! ๐Ÿ˜‰

Where do you plan to address this? The README file or XML documentation in the code?

Awesome, you're still active :)

And should be both README and XML documentation.

Awesome, you're still active :)

Awesome that you're helping! ๐Ÿ˜ƒ

And should be both README and XML documentation.

Sounds like a plan. Looking forward to the PR.

my apologies mate. I realized I logged the issue on the wrong project, to which NCrontab is a dependency.

Did look at the source and NCrontab appears to respect, or rather does not enforce anything that may not have been intentioned by the calling component.

Hence, I'm closing this. I believe there isn't any else that must be done.

my apologies mate. I realized I logged the issue on the wrong project

LOL ๐Ÿ˜†and no worries. Just curious, what's the other project?

Itโ€™s cronDaemon.