ateska / ramona

Enterprise-grade runtime supervisor

Home Page:http://ateska.github.com/ramona/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

os.path.isfile(unix socket) always returns False

RIscRIpt opened this issue · comments

https://github.com/ateska/ramona/blob/master/ramona/socketuri.py#L128

assert not os.path.isfile(fname)

os.path.isfile always returns False on a unix socket file (at least in my system):

>>> sys.version
'2.7.3 (default, Mar 13 2014, 11:03:55) \n[GCC 4.7.2]'
>>> os.path.exists("unix.sock")
True
>>> os.path.isfile("unix.sock")
False
>>>

I think, you should consider changing this assertion, as it always succeed.

Hi,
Very good observation.
I'll change that assertion.
Thanks,
Ales