`isInAws` always returns `false`

Question

meirna opened this issue a year ago · comments

Hey guys, thanks for this library!

I'm having an issue with isInAws function: it always returns false, even in AWS Lambda.

It works for me if I change the condition to:

function isInAWS() {
    return typeof awslambda !== 'undefined';
}

Do you know what might be the reason for this?

Same

AJ Stuyvenberg · Answer 1 · Tue Jun 20 2023 06:42:42 GMT+0800 (China Standard Time)

Hey folks, thanks for flagging this - I was traveling the last few weeks. I'll take a look soon.

I copied this from code we used in datadog's instrumentation which as far as I know still works, however the runtime can always change on us.

Thanks!

AJ Stuyvenberg · Answer 2 · Tue Jun 20 2023 11:08:52 GMT+0800 (China Standard Time)

hey @meirna, @bmul - I've prepared a patch in #7 which seems to work in my manual testing. I'll cut a new release tomorrow.

Thanks!

AJ Stuyvenberg · Answer 3 · Tue Jun 20 2023 20:12:34 GMT+0800 (China Standard Time)

Published in v0.4.0