astrofrog / psrecord

Record the CPU and memory activity of a process :chart_with_upwards_trend:

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix compatibility with latest psutil version

astrofrog opened this issue · comments

get_cpu_percent is now cpu_percent

Just a reminder about this issue which just hit me and looks like it shouldn't be too bad to fix!

@astrofrog - I fixed that on my local copy last week, to be able to use psutil, but I forgot to open a PR ! I can push that later today.

It seems to work for me with the latest dev version, and was going to do another release now.

@saimn - what kind of changes did you have to make?

@astrofrog - saimn@b6d2720
I pushed very quickly as I have to go. I had to use children instead of get_children and changes to get cpu/mem from subprocesses.

@saimn - thanks, I've included your fixes in #19, and added some tests for better coverage.

@joezuntz - the latest developer version should now work correctly (thanks to @saimn's fix). Can you confirm that this is the case? I'm planning on doing a release once the Travis OSX builds work again and I'm able to confirm that this all works fine from a CI point of view.

Yep, works for me now - thanks!

@joezuntz - thanks for confirming! psrecord 1.0 is now out, so closing this.