Speaker not included when writing VTT
agorman opened this issue · comments
Andy Gorman commented
This is a fantastic module thank you. I've noticed that when I read VTT files that it will set the VoiceName field. However, when I write the file back down it doesn't include the speaker.
I'm not sure if this effects other formats as I've only tested with VTT.
Quentin Renard commented
Thanks for reporting the issue. Could you share a test file so that I can reproduce the issue?
Andy Gorman commented
Taken from the Wikipedia article on Web VTT
WEBVTT Kind: captions; Language: en
00:09.000 --> 00:11.000
<v Roger Bingham>We are in New York City
00:11.000 --> 00:13.000
<v Roger Bingham>We are in New York City
00:13.000 --> 00:16.000
<v Roger Bingham>We're actually at the Lucern Hotel, just down the street
00:16.000 --> 00:18.000
<v Roger Bingham>from the American Museum of Natural History
00:18.000 --> 00:20.000
<v Roger Bingham>And with me is Neil deGrasse Tyson
00:20.000 --> 00:22.000
<v Roger Bingham>Astrophysicist, Director of the Hayden Planetarium
00:22.000 --> 00:24.000
<v Roger Bingham>at the AMNH.
00:24.000 --> 00:26.000
<v Roger Bingham>Thank you for walking down here.
00:27.000 --> 00:30.000
<v Roger Bingham>And I want to do a follow-up on the last conversation we did.
00:30.000 --> 00:31.500 align:end size:50%
<v Roger Bingham>When we e-mailed—
00:30.500 --> 00:32.500 align:start size:50%
<v Neil deGrasse Tyson>Didn't we talk about enough in that conversation?
00:32.000 --> 00:35.500 align:end size:50%
<v Roger Bingham>No! No no no no; 'cos 'cos obviously 'cos
00:32.500 --> 00:33.500 align:start size:50%
<v Neil deGrasse Tyson><i>Laughs</i>
00:35.500 --> 00:38.000
<v Roger Bingham>You know I'm so excited my glasses are falling off here.
Quentin Renard commented
Thanks, I've pushed a fix on master
. Could fetch the last changes and let me know whether this is working?
Andy Gorman commented
Looks good. Thank you so much!