asticode / go-astilectron-bundler

Bundle your Astilectron app with ease

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Broken in Go 1.12?

frioux opened this issue · comments

I tried building our astilectron app on go1.12.1 and I get this error:

DEBU[0000] Creating /home/frew/go/src/go.zr.org/auth/zam/output  app_name=
DEBU[0000] Bundling for environment darwin/amd64         app_name=
DEBU[0000] Binding data                                  app_name=
DEBU[0000] Removing /run/shm/astibundler/bind            app_name=
DEBU[0000] Creating /run/shm/astibundler/bind            app_name=
DEBU[0000] Creating /run/shm/astibundler/bind/vendor_astilectron_bundler  app_name=
DEBU[0000] Creating /run/shm/astibundler/cache           app_name=
DEBU[0000] /run/shm/astibundler/cache/astilectron-0.30.0.zip already exists, skipping download of https://github.com/asticode/astilectron/archive/v0.30.0.zip  app_name=
DEBU[0000] Copying /run/shm/astibundler/cache/astilectron-0.30.0.zip to /run/shm/astibundler/bind/vendor_astilectron_bundler/astilectron.zip  app_name=
DEBU[0000] /run/shm/astibundler/cache/electron-darwin-amd64-4.0.1.zip already exists, skipping download of https://github.com/electron/electron/releases/download/v4.0.1/electron-v4.0.1-darwin-x64.zip  app_name=
DEBU[0000] Copying /run/shm/astibundler/cache/electron-darwin-amd64-4.0.1.zip to /run/shm/astibundler/bind/vendor_astilectron_bundler/electron.zip  app_name=
DEBU[0000] Creating /run/shm/astibundler/bind/resources  app_name=
DEBU[0000] Copying /home/frew/go/src/go.zr.org/auth/zam/cmd/zam/resources to /run/shm/astibundler/bind/resources  app_name=
DEBU[0000] Generating /home/frew/go/src/go.zr.org/auth/zam/cmd/zam/bind_darwin_amd64.go  app_name=
DEBU[0001] Removing /home/frew/go/src/go.zr.org/auth/zam/output/darwin-amd64  app_name=
DEBU[0001] Creating /home/frew/go/src/go.zr.org/auth/zam/output/darwin-amd64  app_name=
DEBU[0001] Building for os darwin and arch amd64         app_name=
DEBU[0001] Executing go build -ldflags -X "main.AppName=zam" -X "main.BuiltAt=2019-03-27 08:44:43.753300385 -0700 PDT m=+1.965728088" -o /home/frew/go/src/go.zr.org/auth/zam/output/darwin-amd64/binary .  app_name=
FATA[0002] bundling failed: bundling for environment darwin/amd64 failed: building failed: build cache is required, but could not be located: GOCACHE is not defined and neither $XDG_CACHE_HOME nor $HOME are defined
: exit status 1  app_name=

I know the solution to this, but I think we should stop whitelisting the env vars we pass through to the build and instead pass all env vars through, overriding a specific subset. What do you think?

Sounds good to me. I'll wait for a PR.

Cheers