asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers

Home Page:https://asteroid-team.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cumulative normalization, wrong variance computation

zmolikova opened this issue · comments

Hi,
I suspect that the computation of variance in CumLN is missing a division by the length of the sequence. That is:

cum_var = cum_pow_sum - cum_mean.pow(2)

should be
cum_var = cum_pow_sum / cnt - cum_mean.pow(2)
as in $var(x) = E[x^2] - E[x]^2$.

You're fully right, thank you !

Could you please submit a PR ?