asterisk / asterisk

The official Asterisk Project repository.

Home Page:https://www.asterisk.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[new-feature]: new module: format_aac

viktike opened this issue · comments

Feature Description

Advanced Audio Coding (MP4) format module. Uses libfaac and libfaad external libraries. The configure script needs upgrading to check the new dependencies, but running bootstrap.sh resulted more than the wanted changes, so I didn't add it to my commit.

running bootstrap.sh resulted more than the wanted changes, so I didn't add it to my commit.

What version of autoconf are you using? If you use 2.71 that should minimize the number of changes.

running bootstrap.sh resulted more than the wanted changes, so I didn't add it to my commit.

What version of autoconf are you using? If you use 2.71 that should minimize the number of changes.

I have 2.69 from Ubuntu 20.04 LTS (focal).

It's not looking good:

git diff configure | egrep "^(\+|\-)" | wc -l
18435

Let me know if I should add it to my commit anyway.

Managed to update to 2.71, it's better, but...

git diff configure | egrep "^(\+|\-)" | wc -l
621

It’s fine to be added to the PR and will need to end up there before merge regardless.

It’s fine to be added to the PR and will need to end up there before merge regardless.

Added, thanks.

According to this document: https://web.archive.org/web/20170213191747/https://graphics.ethz.ch/teaching/mmcom12/slides/mp3_and_aac_brandenburg.pdf
It's beneficial to enable Tns (Temporal Noise Reduction) for speech workloads in the encoder, so I just did that.

I've done zero research before asking this question - are there publicly available UACs that support AAC?

I've done zero research before asking this question - are there publicly available UACs that support AAC?

No, I don't think so. But please note, this is a format module (not a codec module), used to read/write files in the filesystem, and has nothing to do with VoIP, just digital audio. This module can be used to Record() or do MixMonitor() with great audio compression and retaining most of the sound quality, which was my primary goal. It can also be used to Playback() or Background() voice prompts in IVRs.

I hope it adds context to your question.

I've done zero research before asking this question - are there publicly available UACs that support AAC?

No, I don't think so. But please note, this is a format module (not a codec module), used to read/write files in the filesystem, and has nothing to do with VoIP, just digital audio.

Ah yes. Boneheaded of me. Thank you for the clarification.

Due to license issues, this module cannot be merged into Asterisk. It's available here: https://github.com/viktike/asterisk-aac