Flaky test: WebHookAction_NonPost_IsNotAllowed
ryanbrandenburg opened this issue · comments
This test fails occasionally with the following error:
Microsoft.AspNetCore.Routing.Matchers.AmbiguousMatchException : The request matched multiple endpoints. Matches:
SlackCoreReceiver.Controllers.SlackController.SlackForCommand (SlackCoreReceiver)
SlackCoreReceiver.Controllers.SlackController.SlackForTrigger (SlackCoreReceiver)
SlackCoreReceiver.Controllers.SlackController.Slack (SlackCoreReceiver)
at Microsoft.AspNetCore.Routing.EndpointConstraints.EndpointConstraintEndpointSelector.SelectAsync(HttpContext httpContext, IEndpointFeature feature, CandidateSet candidates)
at Microsoft.AspNetCore.Routing.Matchers.DfaMatcher.MatchAsync(HttpContext httpContext, IEndpointFeature feature)
at Microsoft.AspNetCore.Routing.GlobalRoutingMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.TestHost.HttpContextBuilder.<>c__DisplayClass10_0.<<SendAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.AspNetCore.TestHost.ClientHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Mvc.Testing.Handlers.CookieContainerHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Mvc.Testing.Handlers.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
at Microsoft.AspNetCore.WebHooks.FunctionalTest.SlackCoreReceiverTest.WebHookAction_NonPost_IsNotAllowed(HttpMethod method) in /_/test/Microsoft.AspNetCore.WebHooks.FunctionalTest/SlackCoreReceiverTest.cs:line 54
--- End of stack trace from previous location where exception was thrown ---
WebHookAction_NonPost_IsNotAllowed failed again.
WebHookAction_NonPost_IsNotAllowed failed again.
WebHookAction_NonPost_IsNotAllowed failed again.
WebHookAction_NonPost_IsNotAllowed failed again.
@dougbu - Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:
-
Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)
- File a bug against the product (#318, now aspnet/Routing#630)
- Is it possible to change the test to avoid the flakiness?
-
Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)
- Is there is a way to change our test to avoid this flakiness?
- Yes? Change the test!
- Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
- Run the test 100 times locally as a sanity check.
- Close this bug
- No?
- Delete the test because flaky tests are not useful (TODO: Link to PR/commit)
- Yes? Change the test!
- Is there is a way to change our test to avoid this flakiness?
See #318 for product bug
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
WebHookAction_NonPost_IsNotAllowed failed again.
This comment was made automatically. If there is a problem contact @ryanbrandenburg.