aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add more tests of ASP.NET Core receivers

dougbu opened this issue · comments

Follow-on work item for #180.

Remaining work includes at least:

  • add functional tests involving signature verification, including unused Stripe and Trello resources
    • Dropbox
    • GitHub
    • Pusher
    • Stripe
    • Trello
  • add functional tests involving request bodies for the samples still missing them
    • DynamicsCRM
    • MailChimp
    • Slack
  • add functional tests of a few other scenarios across the samples
    • HTTP
    • incorrect signature
    • fill gaps e.g. GitHub isn't testing no body case
    • unexpected Content-Type
  • add unit tests of other application model providers, not just WebHookActionModelPropertyProvider
  • add unit tests of other core filters, not just WebHookVerifySignatureFilter
  • add unit tests of remaining receiver-specific filters
    • DropboxVerifySignatureFilter
    • GitHubVerifySignatureFilter
    • PusherVerifySignatureFilter
    • SalesforceVerifyOrganizationIdFilter
    • SlackVerifyTokenFilter
    • StripeTestEventRequestFilter
    • StripeVerifyNotificationIdFilter
  • add unit tests of other core classes
    • WebHookFilterProvider
    • WebHookHttpRequestUtilities
    • WebHookMetadataProvider
    • WebHookRequestReader
  • add unit tests of other receiver-specific classes
    • SalesforceNotificationsModelBinderProvider
    • SalesforceNotificationsModelBinder

Can you add the Vend API to this list as well please?

@Yusha813 you've already opened an issue about supporting the Vend API. Testing should be added as part of #289 or after that work is done. There's no action to take here in the meantime.

Parking in dougbu/add.functional.tests.290.1 branch

Suggest we un-assign this issue, remove the Mapped to Big Rock label, and move it to the 1.0.0-preview3 milestone

This issue was moved to aspnet/AspLabs#40