WebHookSecurityFilter should use `DefaultIdConfigurationKey` in log when id is null or empty

[Pranav K]

WebHooks/src/Microsoft.AspNetCore.WebHooks.Receivers/Filters/WebHookSecurityFilter.cs

Lines 288 to 292 in a05a07c

 Logger.LogError( 
     503, 
     "Could not find a valid configuration for the '{ReceiverName}' WebHook receiver, instance '{Id}'.", 
     sectionKey, 
     id); 

This prints Could not find a valid configuration for the 'github' WebHook receiver, instance '' when the key is invalid.

[Pranav K]

Also

WebHooks/src/Microsoft.AspNetCore.WebHooks.Receivers/Filters/WebHookSecurityFilter.cs

Lines 219 to 220 in a05a07c

 "Could not find a valid configuration for the '{ReceiverName}' WebHook receiver, instance " + 
 "'{Id}'. The value must be between {MinLength} and {MaxLength} characters long.", 

[Pranav K]

Typo:

WebHooks/src/Microsoft.AspNetCore.WebHooks.Receivers/Filters/WebHookSecurityFilter.cs

Line 215 in a05a07c

 // Secrete key found but it does not meet the length requirements. 

[Roman Marusyk]

Hello, do you mean that when the key is invalid should it return other message? I would be glad to fix that if you clarify requirements. Thx

[Pranav K]

@Marusyk no, the intent was to use the term "default id" or something along those lines when the key is the default value. Right now it prints empty quotes, which isn't what the user configures in the log.
Consider

[GitHubWebHook]
public IActionResult Blah() {..}

The log message you see in this case is Could not find a valid configuration for the 'github' WebHook receiver, instance ''. Having '' instance isn't very intuitive. A more appropriate message might be Could not find a valid configuration for the 'github' WebHook receiver, default instance.

[Doug Bunting]

Self-assigning this and two other bugs because we want them done in RC1.

@mkArtakMSFT please add cost: XS label in this repo. This issue and #247 fit in that bucket. Perhaps #245 too.

[ASP.NET Hello Bot]

This issue was moved to aspnet/AspLabs#46