Consider enabling strict roslyn setting

Question

Consider enabling strict roslyn setting

pakrym opened this issue 6 years ago · comments

Eilon Lipton · Answer 1 · Mon Jul 30 2018 12:41:27 GMT+0800 (China Standard Time)

@pakrym - is the main place of value in Kestrel? If so, can you go ahead and run with strict temporarily just to see if there are any issues? (We'd need to fix the issues anyway if/when we enable this globally.)

David Fowler · Answer 2 · Tue Jul 31 2018 00:04:07 GMT+0800 (China Standard Time)

We use structs all over, there’s probably code comparing a StringValues to null elsewhere.

Eilon Lipton · Answer 3 · Tue Jul 31 2018 02:41:24 GMT+0800 (China Standard Time)

OK. We can still preempt a lot of the fallout by fixing up areas where we know it'll be a disaster.

ASP.NET Hello Bot · Answer 4 · Thu Oct 18 2018 02:25:46 GMT+0800 (China Standard Time)

This issue was moved to dotnet/aspnetcore#3645