Maestro-bot updater script failed to update release/2.1

Question

Maestro-bot updater script failed to update release/2.1

natemcmaster opened this issue 6 years ago · comments

https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1609398&_a=summary

2018-04-19T19:39:09.0680672Z Updating  version variables in E:\A\_work\26\s\build\dependencies.props
2018-04-19T19:39:21.3817970Z ##[error]error: src refspec dotnetbot/UpdateDeps does not match any.
error: failed to push some refs to 'https://@github.com/aspnet/Universe.git'
E:\A\_work\26\s\scripts\UpdateDependencies.ps1 : Cannot bind argument to 
parameter 'Message' because it is null.
At line:1 char:1
+ & "E:\A\_work\26\s\scripts\UpdateDependencies.ps1" -BuildXml https:// ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [UpdateDependencies.ps1], Param 
   eterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,U 
   pdateDependencies.ps1

cc @ryanbrandenburg

Ryan Brandenburg · Answer 1 · Sat Apr 21 2018 06:48:59 GMT+0800 (China Standard Time)

I sent a PR for this, self-assigning to track until we've confirmed that it works through Maestro.

Nate McMaster · Answer 2 · Tue Apr 24 2018 23:45:02 GMT+0800 (China Standard Time)

New error.

remote: Permission to aspnet/Universe.git denied to dotnet-maestro-bot.
Your branch is ahead of 'origin/release/2.1' by 1 commit.
  (use "git push" to publish your local commits)
E:\A\_work\26\s\scripts\UpdateDependencies.ps1 : Cannot bind argument to
Process completed with exit code 0 and had 3 error(s) written to the error stream.

Before switching to hub.exe, the way this worked is that dotnet-maestro-bot would push to its fork of Universe, https://github.com/dotnet-maestro-bot/Universe

https://devdiv.visualstudio.com/DevDiv/_build?buildId=1624020&_a=summary

Ryan Brandenburg · Answer 3 · Wed Apr 25 2018 01:43:56 GMT+0800 (China Standard Time)

Reacting with #1111.

Ryan Brandenburg · Answer 4 · Fri Apr 27 2018 01:22:09 GMT+0800 (China Standard Time)

So, the script works on Maestro now, but it's reported as a failure because it picks a couple lines and decides that they're errors. See here.

Nate McMaster · Answer 5 · Fri Apr 27 2018 03:01:50 GMT+0800 (China Standard Time)

I think VSTS isn't happy because git.exe is writing to stderr. Also, we should add a check for an existing PR and update that one instead of creating a new PR.

 Error creating pull request: Unprocessable Entity (HTTP 422) A pull request already exists for dotnet-maestro-bot:rybrande/UpgradeDepsTest.

Ryan Brandenburg · Answer 6 · Fri Apr 27 2018 05:52:01 GMT+0800 (China Standard Time)

We pushed to the same branch that the maestrobot used last time, so we DID update the PR. Do we want to update the text of the message as well?

Ryan Brandenburg · Answer 7 · Fri Apr 27 2018 05:52:32 GMT+0800 (China Standard Time)

Let's double check that we're using Invoke-Block everywhere so Powershell doesn't make us miss failures now that we're ignoring StdErr.

Ryan Brandenburg · Answer 8 · Fri Apr 27 2018 05:55:13 GMT+0800 (China Standard Time)

We're good on Invoke-Blocks, so the only work item left here would be if we wanted to update PR text.

Ryan Brandenburg · Answer 9 · Tue May 01 2018 05:59:10 GMT+0800 (China Standard Time)

Closing this since there's no reply. @natemcmaster if you had further comments feel free to re-open.