Create a dev branch
alexbocharov opened this issue · comments
Please, create a new development branch for pushing changes to the repository.
I'm ready to make pull request (https://github.com/alexbocharov/SignalR-Client-Net)
/cc @Eilon @davidfowl @DamianEdwards
Steps:
- Migrate client https://github.com/SignalR/SignalR (as is)
- Integration dependencies https://github.com/aspnet/Logging (Replacing trace)
- Integration dependencies https://github.com/aspnet/SignalR-Server (Shared code)
@DamianEdwards thoughts on the priority of this and whether it's actionable right now? I was under the impression we wanted to do some much larger changes than just porting the code to use the new ASP.NET Core types...
cc @davidfowl too
@Eilon
Are you planning to develop from scratch?
I did a starting point for further work. What are your plans for work?
@alexbocharov probably not from scratch, but there might be some larger re-designing that we want to do.
@alexbocharov probably not from scratch, but there might be some larger re-designing that we want to do.
@Eilon I started working on it. I change dependences for SignalR-Server.
Next steps:
- Integration Logging
- Integration SignalR-Server
- Refactoring code
@alexbocharov I understand, but I'm not sure those are the first tasks that need to be tackled. "Refactoring code" is pretty vague.
"Refactoring code" is pretty vague.
@Eilon I set a goal to remove duplicate code. There are many a duplicate code (Client - Server).
It is the early version of the client.
Sorry for my bad English
We would need to discuss with @DamianEdwards and @davidfowl before proceeding.
@Eilon Ok. I would be grateful for the direction of future work.